Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App::runningInConsole() returning true on web function when octane is turned on #150

Open
brain82 opened this issue Jan 15, 2024 · 1 comment

Comments

@brain82
Copy link

brain82 commented Jan 15, 2024

This appears to be because Octane runs using the PHP CLI (console).

As a quick fix, I've updated my function, as highlighted below. However, it will be great to have this as the default.

PS: Thanks for the great work!

image

@mnapoli
Copy link
Member

mnapoli commented Jan 15, 2024

Thanks for opening this, full context:

Screen-001523

We probably want this line in our Octane handler: https://github.com/laravel/octane/blob/2.x/bin/bootstrap.php#L8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants