Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper key restore race condition #23

Open
tofutim opened this issue Jul 7, 2018 · 0 comments
Open

paper key restore race condition #23

tofutim opened this issue Jul 7, 2018 · 0 comments

Comments

@tofutim
Copy link

tofutim commented Jul 7, 2018

Under certain conditions, in particular, in a paper key restore, the merkleblock can arrive before the transaction. In this case, the transaction will not receive blockheight and timestamp in BRWalletUpdateTransaction as called by _peerRelayedBlock. When BRWalletRegisterTransaction is later called, BRWalletUpdateTransaction is never called again.

I'm trying to figure out if there is a way to look up stored merkleblocks for the transaction, or cache the UpdateTransaction info... maybe a map of txhash to block? or a BRSet of blocks to check for txs? I need a hash table!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant