Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add formatLandlinePhone()/formatMobilePhone()/formatPhone() #186

Open
silvioprog opened this issue Dec 8, 2020 · 3 comments

Comments

@silvioprog
Copy link
Contributor

Hi.

It would be nice to provide the following format functions:

  • formatLandlinePhone(landlinePhone: string): string - Formats a landline phone, e.g.: 9999999999(99) 9999-9999;
  • formatMobilePhone(mobilePhone: string): string - Formats a mobile phone, e.g.: 99999999999(99) 99999-9999;
  • formatPhone(phone: string): string - Formats a landline or mobile phone, e.g.: 9999999999(99) 9999-9999 or 99999999999(99) 99999-9999.

cheers

@hyanmandian
Copy link
Member

Hello @silvioprog , maybe #155 solve your problem. What do you think? If not, we can split this function in three like you suggested.

@silvioprog
Copy link
Contributor Author

Hello @hyanmandian, I'm going to test it, but a quickly look at the sources it seems will work like a charm. 😃

Maybe a split would be nice to avoid overheads when the programmer wants to format only one type (eg: mobile phone) .

@hyanmandian
Copy link
Member

What do you think to implement these functions in #155 ? If you need some help, I can help you with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants