Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

replace moment with date-fns for date helpers #11061

Closed
cezaraugusto opened this issue Sep 21, 2017 · 5 comments · Fixed by #11062
Closed

replace moment with date-fns for date helpers #11061

cezaraugusto opened this issue Sep 21, 2017 · 5 comments · Fixed by #11062
Assignees
@cezaraugusto
Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude sec-low security
Milestone
0.23.x (Release C...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Sep 21, 2017 •
edited by luixxiul

Test plan

#11062 (comment)

Initially, the plan was to reduce bundle cost given moment is enourmous. However after reading this and looking at this this killed two birds with one stone.
@cezaraugusto cezaraugusto added this to the 0.21.x (Nightly Channel) milestone Sep 21, 2017
@cezaraugusto cezaraugusto self-assigned this Sep 21, 2017
@cezaraugusto
Copy link
Contributor Author

EDIT: Turns out that Joi has it as a dependency so I don't think we can remove it completely. Based on that if this is still a security problem but unsolvable ATM please let me know

cezaraugusto added a commit that referenced this issue Sep 21, 2017
@cezaraugusto
replace momentjs with date-fns
b29c9b8 
#11061
@cezaraugusto cezaraugusto mentioned this issue Sep 21, 2017
Merged
@diracdeltas
Copy link
Member

@cezaraugusto it looks like joi is only used in tools/transactionHelpers.js which is not a package dependency, only a dev dependency (unless i'm mistaken)

@diracdeltas
Copy link
Member

actually joi is used in the ledger packages, but it looks like Joi no longer uses moment: hapijs/joi#1037

cezaraugusto added a commit that referenced this issue Sep 21, 2017
@cezaraugusto
update joi version in package-lock
7ec0f49 
also updates joi in ledger-client
address #11061
@diracdeltas diracdeltas mentioned this issue Sep 23, 2017
Closed
8 tasks
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel), Backlog Oct 25, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, 0.23.x (Nightly Channel) Feb 8, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
This was referenced Jun 19, 2018
Closed
Closed
Closed
@brave brave deleted a comment from srirambv Jun 20, 2018
@LaurenWags
Copy link
Member

QA Blocked on #14407

This was referenced Jun 21, 2018
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 25, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 25, 2018 •
edited by LaurenWags

Verified on Windows 10 x64 using

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.17 - bc754eb
  • Muon - 7.1.2
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.17 bc754eb
  • Muon 7.1.2
  • libchromiumcontent 67.0.3396.87

This was referenced Jun 25, 2018
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude sec-low security
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

replace momentjs with date-fns brave/browser-laptop
9 participants
@diracdeltas @bbondy @kjozwiak @luixxiul @cezaraugusto @bsclifton @srirambv @LaurenWags @btlechowski