Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enums to improve readability #6

Open
brandonmanke opened this issue Dec 24, 2017 · 0 comments
Open

Add Enums to improve readability #6

brandonmanke opened this issue Dec 24, 2017 · 0 comments

Comments

@brandonmanke
Copy link
Owner

brandonmanke commented Dec 24, 2017

Enums based off of some of the enums or objects in the API would help make parameters easier to understand and improve readability. For example membershipType constructing a simple enum based off of the API Enum type.

const destinyMembershipType = {
  None: 0,
  TigerXbox: 1,
  TigerPsn: 2,
  TigerBlizzard: 4,
  TigerDemon: 10,
  BungieNext: 254,
  All: -1
};

Will probably include them in their own seperate file, named destiny-types or something.

@brandonmanke brandonmanke changed the title Added Enums to improve readability Add Enums to improve readability Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant