Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak - Chrome #157

Open
Millsky opened this issue Sep 26, 2017 · 0 comments
Open

Memory Leak - Chrome #157

Millsky opened this issue Sep 26, 2017 · 0 comments

Comments

@Millsky
Copy link

Millsky commented Sep 26, 2017

The player is leaking memory when the events bound to the Iframe are not destroyed properly.
To reproduce this issue in Chrome Version: 61.0.3163.100 (Official Build) (64-bit)

1.) Open http://brandly.github.io/angular-youtube-embed/#/advanced
2.) Take an initial heap snapshot in chrome devtools
3.) toggle the ng-if example on and off while waiting for the video to load.
4.) Take another heap snapshot.
5.) Repeat the process.

As seen below the heap size will consistently increase.

screen shot 2017-09-26 at 4 39 27 pm

The root cause appears to be the angular scope on the events being passed into the call to the YT Iframe API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant