Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Braintree\Base::jsonSerialize() #306

Open
MarkBCG opened this issue Dec 4, 2021 · 4 comments
Open

Braintree\Base::jsonSerialize() #306

MarkBCG opened this issue Dec 4, 2021 · 4 comments
Labels
next major version triaged

Comments

@MarkBCG
Copy link

MarkBCG commented Dec 4, 2021

General information

  • SDK/Library version: 6.5.0
  • Environment: Sandbox
  • Language, language version, and OS: PHP 8.1.0, Debian

Issue description

In the latest version of the library, this "Deprecated" notice is being reported.

Deprecated: Return type of Braintree\Base::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vendor/braintree/braintree_php/lib/Braintree/Base.php on line 82
@hollabaq86
Copy link
Contributor

👋 @MarkBCG thanks for the report, don't have an ETA but we'll fix this up.

@hollabaq86
Copy link
Contributor

Sorry folks didn't have coffee when I commented earlier 🙃 , we added the #[\ReturnTypeWillChange] to temporarily suppress these warnings in version 6.5.1. But we haven't addressed the source of the deprecation warning. Going to leave this issue open until we've addressed the underlying source of the issue.

@hollabaq86
Copy link
Contributor

for internal tracking, ticket 1401

hollabaq86 pushed a commit that referenced this issue Jan 11, 2023
Dtbtsdk 655 - Bring ThreeDSecureInfo to parity (#306)
65b5fbe 
* Document threeDSecure info - integration tests currently blocked by the
gateway

Co-authored-by: Holly Stotelmyer <holly.stotelmyer@getbraintree.com>
Co-authored-by: Joe Plukarski <joseph.plukarski@getbraintree.com>
@piegus
Copy link

piegus commented Apr 22, 2024

any ETA???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next major version triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@piegus @hollabaq86 @MarkBCG