Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have ResourceCollection<T> implement IAsyncEnumerable #105

Open
richardszalay opened this issue Nov 19, 2020 · 2 comments
Open

Have ResourceCollection<T> implement IAsyncEnumerable #105

richardszalay opened this issue Nov 19, 2020 · 2 comments
Labels

Comments

@richardszalay
Copy link

richardszalay commented Nov 19, 2020

General information

  • SDK/Library version: 5.2.0
  • Environment: (Development)
  • Language, language version, and OS: C# 8 / .NET Core 3.1

Issue description

ResourceCollection<T> implements IEnumerable<T>, but this requires the use of blocking IO in the *Gateway classes. Implementing IAsyncEnumerable would allow enumeration to be non-blocking.

@hollabaq86
Copy link
Contributor

👋 @richardszalay thanks for the suggestion! It doesn't look like IAsyncEnumerable is available for .NET framework versions lower than 5.0, so we'd need to add some preprocessor directives to make sure we're still supporting older versions (we target Net Framework 4.5.2 and Net Standard 2.0).

If you'd like to submit a PR that implements this, please go for it 😄

@hollabaq86
Copy link
Contributor

For internal notekeeping - ticket number 1613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants