Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiViewICA #500

Open
hugorichard opened this issue Apr 23, 2021 · 9 comments
Open

MultiViewICA #500

hugorichard opened this issue Apr 23, 2021 · 9 comments

Comments

@hugorichard
Copy link
Contributor

I have developped recently a new method called MultiViewICA.
https://proceedings.neurips.cc/paper/2020/file/de03beffeed9da5f3639a621bcab5dd4-Paper.pdf
It does the same thing as SRM but yields significantly better results.
I currently have a standalone implementation of it here:
https://github.com/hugorichard/multiviewica
In practice, I use SRM to reduce the data and MultiViewICA is applied on the reduced data.
I believe it would be nice to have it directly in Brainiak so that users can use it more easily.
If you think this is a good idea, I'll make a pull request.

@mihaic
Copy link
Member

mihaic commented Apr 23, 2021

Hello, @hugorichard! I think that's a great idea. Aside from python-picard, which looks fine, I see no new dependencies.

Let's hear also from our SRM team. @TuKo, @qihongl?

@hugorichard
Copy link
Contributor Author

Actually I would like to make https://github.com/hugorichard/multiviewica
a dependency as other people are already relying on this code. Would that be fine with you ?

@mihaic
Copy link
Member

mihaic commented Apr 23, 2021

In that case, what would the BrainIAK contribution be?

@hugorichard
Copy link
Contributor Author

This integration of SRM and MultiViewICA

@hugorichard
Copy link
Contributor Author

so that people can just do MultiViewICA.fit() and it performs first SRM and then MultiViewICA on reduced data.

@mihaic
Copy link
Member

mihaic commented Apr 23, 2021

I see. It seems to me less compelling than incorporating MultiViewICA, but let's hear from others as well...

@lcnature
Copy link
Contributor

lcnature commented May 3, 2021

Hi @hugorichard. Thanks for thinking of contributing to BrainIAK! Since the major code is not going to come into BrainIAK, how do you think about making a new example notebook in funcalign folder that shows how to use SRM and MultiViewICA together?

@hugorichard
Copy link
Contributor Author

Hi @lcnature ! I think that is a great idea. If you think that's interesting, I'll work on that.

@mihaic
Copy link
Member

mihaic commented May 5, 2021

Yes, an example would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants