Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[matnormal] Matnormal covs should be ported to tf.linalg.LinearOperators when possible #489

Open
mshvartsman opened this issue Dec 25, 2020 · 0 comments

Comments

@mshvartsman
Copy link
Contributor

A lot of the structure-exploiting linear algebra in brainiak.matnormal is basically the same as in tf.linalg.LinearOperator. I'm not sure if I didn't know about it or it didn't exist in its current form when I did the original implementations, but we can probably remove a lot of code if most brainiak.matnormal.covs are just thin shims around LinearOperators. This would also buy us any future improvements on the TF side (in particular, moving scaling from cubic to quadratic if and when someone ports https://arxiv.org/pdf/1809.11165.pdf to TF), and batch support for covs. I have a few other things on my plate before getting to this (for one, porting MN-SRM to TF2) but this would be a nice way for someone else to get their hands dirty with brainiak.matnormal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant