Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 17.x #734

Open
mneira10 opened this issue Sep 13, 2021 · 11 comments
Open

Support React 17.x #734

mneira10 opened this issue Sep 13, 2021 · 11 comments

Comments

@mneira10
Copy link

Hey! Thanks for such a cool library!

Currently, react-carousel supports up to version 16.8.0 of react. It would be awesome if it would support 17.x!

@amymorrisonsky
Copy link

May I ask what issues you ran into?

@m99coder
Copy link

m99coder commented Sep 17, 2021

If your project uses React 17, an npm install will fail and only succeed with the --legacy-peer-deps flag as follows:

npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from @brainhubeu/react-carousel@2.0.4
npm ERR! node_modules/@brainhubeu/react-carousel
npm ERR!   @brainhubeu/react-carousel@"^2.0.4" from the root project

Luckily it works out of the box in React 17. Just annoying that you have to use this dangerous flag for installing it.

@mhraihan
Copy link

If your project uses React 17, an npm install will fail and only succeed with the --legacy-peer-deps flag as follows:

npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from @brainhubeu/react-carousel@2.0.4
npm ERR! node_modules/@brainhubeu/react-carousel
npm ERR!   @brainhubeu/react-carousel@"^2.0.4" from the root project

Luckily it works out of the box in React 17. Just annoying that you have to use this dangerous flag for installing it.

I'm facing the same problem :(

@mneira10
Copy link
Author

If your project uses React 17, an npm install will fail and only succeed with the --legacy-peer-deps flag as follows:

npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from @brainhubeu/react-carousel@2.0.4
npm ERR! node_modules/@brainhubeu/react-carousel
npm ERR!   @brainhubeu/react-carousel@"^2.0.4" from the root project

Luckily it works out of the box in React 17. Just annoying that you have to use this dangerous flag for installing it.

Good to know! It would be better for the peace of mind to install it without the dangerous flag though

@christian-pletz
Copy link

If your project uses React 17, an npm install will fail and only succeed with the --legacy-peer-deps flag as follows:

npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from @brainhubeu/react-carousel@2.0.4
npm ERR! node_modules/@brainhubeu/react-carousel
npm ERR!   @brainhubeu/react-carousel@"^2.0.4" from the root project

Luckily it works out of the box in React 17. Just annoying that you have to use this dangerous flag for installing it.

Same issue here... Please update the dependency configuration.

@flokress
Copy link

flokress commented Oct 11, 2021

Would be great if react 17 is supported. please update the dependencies.

@Mixomoda
Copy link

Please support react 17.x

@edcheyjr
Copy link

Please support react 17.x

yes, please do

@thisKeeWord
Copy link

please

@EduardoNGomes
Copy link

@lsilvahbo
Copy link

Here's the patch for React 17-18
https://www.npmjs.com/package/@itseasy21/react-elastic-carousel

and update your imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests