Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the best way to generate multiple views of a sample (window) in Braindecode? #547

Open
MohammadJavadD opened this issue Oct 4, 2023 · 1 comment
Assignees

Comments

@MohammadJavadD
Copy link
Contributor

MohammadJavadD commented Oct 4, 2023

In PyTorch SimCLR and follow-up papers used a simple class to apply transforms to a batch. (See Here).
Here in Braindecode, if we do the same we get an error in the AugmentDataloader as transforms are not a list or accepted format. If we create a new dataset, it is super slow. I think it applies augmentations on the CPU for each sample separately and serially. Any suggestion to speed up the process? In my implementation, it is 1000X faster without augmentation!

@bruAristimunha
Copy link
Collaborator

Hey @MohammadJavadD! (cc. @robintibor)

We have recently improved dataset creation, and we have studied in depth how to generate dataset more efficiently. We came to the conclusion that it wasn't as slow as we thought, we were just using it wrong.

To make the discussion more fruitful, can you provide a minimum viable code that shows the slowness? We did not do this study with an augmentation module, maybe there is something to improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants