Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between doc and code in create_fixed_length_windows #509

Open
apmellot opened this issue Sep 7, 2023 · 0 comments
Open

Inconsistency between doc and code in create_fixed_length_windows #509

apmellot opened this issue Sep 7, 2023 · 0 comments

Comments

@apmellot
Copy link

apmellot commented Sep 7, 2023

The doc says :
"window_stride_samples (int | None) – Stride between windows in samples. If None, set to be equal to winddow_size_samples, so windows will not overlap."
but when window_stride_samples is None and window_size_samples is not, we get an assertion error.
window_stride_samples is not set to be equal to window_size_samples :
https://github.com/braindecode/braindecode/blob/master/braindecode/preprocessing/windowers.py#L583

@apmellot apmellot changed the title Inconsinstency between doc and code in create_fixed_length_windows Inconsistency between doc and code in create_fixed_length_windows Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant