Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis file bug #45

Open
luizperes opened this issue Jul 11, 2017 · 4 comments
Open

Travis file bug #45

luizperes opened this issue Jul 11, 2017 · 4 comments

Comments

@luizperes
Copy link
Member

Travis is not working properly. PR #44 was supposed to have broken, but it is not, once Travis is downloading my dev branch instead.

@rafaelcn
Copy link
Collaborator

Is this still a problem?

@luizperes
Copy link
Member Author

For sure :)

@rafaelcn
Copy link
Collaborator

That should be fixed in docker, doesn't it? I just saw the Travis CI for #44 and it has shown:

$ docker pull luizperes/brain
latest: Pulling from luizperes/brain
Status: Downloaded newer image for luizperes/brain:latest
$ docker run -i luizperes/brain /bin/sh -c "cd /root/ && rm -rf brain && git clone https://github.com/luizperes/brain.git && cd /root/brain/ && git checkout dev && make build-travis SUDO?= && export PATH=$PATH:/root/brain/bin && make install && make tests"

Maybe an special docker image for Travis CI? Or remove the usage of docker image in travis, sounds reasonable?

@luizperes
Copy link
Member Author

Yeah, I will need to remake it xD I had trouble doing that the first time I tried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants