Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump puppeteer-core from 5.5.0 #286

Open
baruchiro opened this issue Sep 25, 2021 · 3 comments
Open

Bump puppeteer-core from 5.5.0 #286

baruchiro opened this issue Sep 25, 2021 · 3 comments
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com

Comments

@baruchiro
Copy link
Collaborator

We can't upgrade puppeteer-core because its types are broken: puppeteer/puppeteer#7100

I think we should try to find a solution, since the puppeteer is a core library in our project. Please see the attached issue in puppeteer to see potential solutions.
@baruchiro baruchiro mentioned this issue Sep 25, 2021
Closed
@baruchiro baruchiro added dependencies Pull requests that update a dependency file good first issue Good for newcomers labels Sep 29, 2021
@baruchiro baruchiro mentioned this issue Oct 3, 2021
Closed
@baruchiro baruchiro added the hacktoberfest https://hacktoberfest.digitalocean.com label Oct 5, 2021
@shacharRonZohar
Copy link

shacharRonZohar commented May 10, 2023 •
edited

Is this still a relevant issue? Puppeteer has reached version 20.1.2, which seems like a rather large jump from the current 5.5.0, with some breaking changes to be expected.

If this bump is still wanted I can try tackling it.

@baruchiro
Copy link
Collaborator Author

Yes, it is still relevant. Upgrading packages is sometimes hard in our project, but we have to do that!

There are some issues that I think we shouldn't try to solve before upgrading their packages.

Thank you!

@shacharRonZohar
Copy link

Hey, just wanted to give an update, due to some personal circumstances I have been unable to start work on this.
I'm posting this here because as much as I would love to come back to it when I can, in the meantime I don't want to block it, so if anyone wants to work on this, feel free!

I'll give another update here if \ when I am able to continue work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baruchiro @shacharRonZohar