Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot focus "add column" button #847

Closed
barmac opened this issue Apr 5, 2024 · 1 comment · Fixed by #869
Closed

Cannot focus "add column" button #847

barmac opened this issue Apr 5, 2024 · 1 comment · Fixed by #869
Assignees
@barmac
Labels
a11y bug Something isn't working good first issue Good for newcomers

Comments

@barmac
Copy link
Member

barmac commented Apr 5, 2024 •
edited by nikku

Describe the Bug

The "add column" button (+) is inaccessible with the keyboard as it's a span without tabindex.

Steps to Reproduce

Try to focus it.

Expected Behavior

It should be a button with accessible label.

Environment

Please complete the following information:

  • Browser: [e.g. IE 11, Chrome 69]
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]

Child of https://github.com/bpmn-io/internal-docs/issues/909
@barmac barmac added bug Something isn't working ready Ready to be worked on a11y labels Apr 5, 2024
@nikku nikku added the good first issue Good for newcomers label Apr 10, 2024
barmac added a commit that referenced this issue May 23, 2024
@barmac
fix: make add column buttons focussable
4eb6b75 
Closes #847
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label May 23, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the ready Ready to be worked on label May 23, 2024
@barmac barmac mentioned this issue May 23, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels May 23, 2024
barmac added a commit that referenced this issue May 24, 2024
@barmac
fix: make add column buttons focussable
a7f7754 
Closes #847
@barmac
Copy link
Member Author

barmac commented May 27, 2024

Closed via #869

@barmac barmac closed this as completed May 27, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
a11y bug Something isn't working good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make add column buttons focussable bpmn-io/dmn-js
2 participants
@nikku @barmac