Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect calculation of the number of lines in a badge if it was added to the repository at the start #431

Open
pomponchik opened this issue Feb 24, 2024 · 3 comments

Comments

@pomponchik
Copy link

pomponchik commented Feb 24, 2024

Hello!

I have added your experimental badge to several of my repositories. Several of them work fine, and several always display the same fixed number of lines: 18.

The badge works fine in these repositories:

But! For these repositories, "18" is always displayed:

I guess the difference is that in the second group of repositories, the badge was added at the start. I put the badge in the develop branch and they got into the main with the first PR.

@boyter
Copy link
Owner

boyter commented Feb 25, 2024

Its usually a case of github caching it. If you look at the actual rendered link it goes though githubs servers first.

For example https://camo.githubusercontent.com/b19935ed836c142d0eb7b654cc2045c600b5cfd273f316f16760af3511b722d0/68747470733a2f2f736c6f632e78797a2f6769746875622f706f6d706f6e6368696b2f7369676d617463682f3f63617465676f72793d636f6465 is the link for sigmatch from the above.

I don't actually know how to bust this cache myself....

While the badge server does cache as well its not as aggressive as the github one.

@pomponchik
Copy link
Author

pomponchik commented Feb 27, 2024

I found the answer!

Look:

You need only a question sign.

I think we should add it to the docs.

@boyter
Copy link
Owner

boyter commented Feb 27, 2024

I think that will only bust the cache once though. Of course you can always add more at the end to rebust it.

Ill have a look through that thread because there might be some other solutions raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants