Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Versioning] Change package.json to use current lighthouse version #10

Open
cmaerz opened this issue Oct 17, 2018 · 3 comments
Open

[Versioning] Change package.json to use current lighthouse version #10

cmaerz opened this issue Oct 17, 2018 · 3 comments

Comments

@cmaerz
Copy link

cmaerz commented Oct 17, 2018

Currently Lighthouse version is hardcoded to ^3.0.3 maybe it's a good idea to switch this to ^3 to always use the newest version within the current major of lighthouse.

@mattpaulwilliamson
Copy link

mattpaulwilliamson commented Nov 28, 2018

Hi @cmaerz the current carrot on ^3.0.3 means it would take the latest minor and patch the change your are suggesting would mean it would still just have the same outcome.

To do what you have suggested I think the following could work and it would get the latest major version: "lighthouse": "*", in the package.json

This is a nice explanation: https://docs.npmjs.com/about-semantic-versioning

@cmaerz
Copy link
Author

cmaerz commented Nov 28, 2018

Hm ok, i got this. But why did i get 3.0.3 on my first install then?

@mattpaulwilliamson
Copy link

I would expect it to use the 3.2.1 release of lighthouse once installed. As this is the last minor V3 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants