Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add digital ocean button #583

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add digital ocean button #583

wants to merge 11 commits into from

Conversation

G3root
Copy link
Contributor

@G3root G3root commented Oct 6, 2022

What does this PR do?

Fixes #60.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@ghost
Copy link

ghost commented Oct 6, 2022 •
edited by ghost

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@devkiran devkiran requested a review from niwsa October 7, 2022 15:01
@niwsa
Copy link
Member

niwsa commented Oct 9, 2022

@G3root The deploy is failing for me. Hitting below error. For testing I created a fork of the repo and authorized DO access for the repo. Were you able to get it running ?
Screenshot 2022-10-09 at 9 35 56 PM

@G3root
Copy link
Contributor Author

G3root commented Oct 10, 2022

@G3root The deploy is failing for me. Hitting below error. For testing I created a fork of the repo and authorized DO access for the repo. Were you able to get it running ? Screenshot 2022-10-09 at 9 35 56 PM

pushed some changes. now it's working.
Screenshot from 2022-10-10 23-25-25

devkiran
devkiran suggested changes Oct 11, 2022
View reviewed changes
.do/deploy.template.yaml Show resolved Hide resolved
.do/deploy.template.yaml Outdated Show resolved Hide resolved
.do/deploy.template.yaml Show resolved Hide resolved
@devkiran
Copy link
Contributor

@G3root type: SECRET doesn't allow me to change the value.
DigitalOcean-App-Platform

@G3root G3root requested review from devkiran and removed request for niwsa October 11, 2022 13:42
@devkiran
Copy link
Contributor

Unfortunately, the DigitalOcean build is failed on the last step.

@G3root
Copy link
Contributor Author

G3root commented Oct 11, 2022

Unfortunately, the DigitalOcean build is failed on the last step.

is the error specific to deploy.template.yaml or others ?

@niwsa
Copy link
Member

niwsa commented Oct 11, 2022

This is where it fails for me.

Screenshot 2022-10-11 at 10 42 54 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devkiran devkiran Awaiting requested review from devkiran

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DigitalOcean 1-Click App
3 participants
@G3root @niwsa @devkiran