Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jQuery and replace deprecated things in the default admin theme #796

Open
evrifaessa opened this issue Dec 15, 2020 · 3 comments
Open
Labels
admin panel compatibility For Issues and Pull Requests involving compatibility across different types of dependencies. dependencies Issues and Pull Requests involving the dependencies of BoxBilling. deprecated For issues or pull requests involving fixes or replacements made to deprecated dependencies. front-end Updating what's being seen by the end-user help wanted javascript Pull requests that update Javascript code security For bugs/exploits involving security. task Task required by a developer

Comments

@evrifaessa
Copy link
Collaborator

When the admin_default theme was written, the latest version of jQuery was v1.7.1.

As of today, jQuery v3.5.1 is the latest version available, and the 1.x. and 2.x. versions no longer receive patches.
Developers who want to create new extensions mostly take the default layout that comes from the admin_default theme. There were some breaking changes in new jQuery version, and some functionalities of the latest jQuery does not exist in v.1.7.1. Hence, we need to update our jQuery and update it to comply with breaking changes.

@evrifaessa evrifaessa added compatibility For Issues and Pull Requests involving compatibility across different types of dependencies. dependencies Issues and Pull Requests involving the dependencies of BoxBilling. deprecated For issues or pull requests involving fixes or replacements made to deprecated dependencies. javascript Pull requests that update Javascript code labels Dec 15, 2020
@stale
Copy link

stale bot commented Feb 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. The resources of the BoxBilling team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open. If this is a feature request, and you feel that it is still relevant and valuable, please tell us why. This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the stale label Feb 13, 2021
@stale stale bot closed this as completed Feb 20, 2021
@evrifaessa evrifaessa removed the stale label Mar 24, 2021
@evrifaessa evrifaessa reopened this Mar 24, 2021
@evrifaessa evrifaessa added front-end Updating what's being seen by the end-user security For bugs/exploits involving security. labels Aug 10, 2021
@evrifaessa evrifaessa pinned this issue Aug 10, 2021
@BelleNottelling
Copy link
Collaborator

I mentioned this in slack a while back, but we can use jquery-migrate to help with this process.
The lazy solution is it use the "production" version and update the bare minimum of what breaks.
The proper solution is to use the "development" version which will alert us in the browser console about which outdated functions are used, which should make it fairly straightforward to identify functions and plugins that need to be updated so we can use the latest jQuery version without the migrate library

@evrifaessa evrifaessa unpinned this issue Aug 18, 2021
@BelleNottelling BelleNottelling pinned this issue Aug 20, 2021
@notbasetwo
Copy link
Contributor

notbasetwo commented Aug 22, 2021

This needs to be split in to two steps - first migrating from 1.7.x to >=1.19 and then from >=1.19 to 3.x -- if using jquery-migrate that is.

@evrifaessa evrifaessa added admin panel task Task required by a developer labels Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin panel compatibility For Issues and Pull Requests involving compatibility across different types of dependencies. dependencies Issues and Pull Requests involving the dependencies of BoxBilling. deprecated For issues or pull requests involving fixes or replacements made to deprecated dependencies. front-end Updating what's being seen by the end-user help wanted javascript Pull requests that update Javascript code security For bugs/exploits involving security. task Task required by a developer
Projects
None yet
Development

No branches or pull requests

3 participants