Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't export all items #16

Open
pooria121 opened this issue Jan 13, 2021 · 3 comments
Open

Doesn't export all items #16

pooria121 opened this issue Jan 13, 2021 · 3 comments

Comments

@pooria121
Copy link

We are using VueyeComponent to display a very paginated large table (with 300,000 rows).
Currently, the excel export button would export rows that are currently displayed:

const items = computed(() => {
            return props.sharedState.currentPageItems;
        });

However, many applications (including ours) require exporting the entire table for further processing.
Displaying the entire 300,000 in a single page can get us by, but most often result in crashing the HTML page.

I would argue that the Excel export button should export all the data passed to the table, or at least there should be a flag to set/control this behavior.

@boussadjra
Copy link
Owner

Exporting a big amount of data could also crashe the app since the exporting process creates a table under hood then export it to excel

@pooria121
Copy link
Author

Agreed, but it hard to define "big". For example, in our case, 300000 is not big enough to crash the app when you create a table in memory that is not going to be displayed (and just exported!) - but forcing 300000 to be displayed before being exported (current code) would definitely crash due to unnecessary rendering. Thus, I think it is a good idea to give developers the agility to configure this behavior.

@boussadjra
Copy link
Owner

I didn't have that amount of data to test it, you could take this code and try it out and let me know if that doesn't affect the performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants