Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all pieces come from the same object while do multi-part downloading. #86

Open
shileiyu opened this issue May 16, 2017 · 1 comment

Comments

@shileiyu
Copy link

shileiyu commented May 16, 2017

I have done a quick search against the latest code on develop branch, the IFMatch prediction wasn't used in multi-part downloading task.
if someone patches or replaces the file during downloading(large file or slow network), the result may be end up as a mix-in of multiple revisions, especially when chunk size is small.

@jamesls
Copy link
Member

jamesls commented Jun 12, 2017

Just to clarify, the idea is to take the ETag value we get during the head_object call and pass it through all the get_object() calls. If we get a 412 error then we mark the object as a failed (or retry again from the beginning). Is that right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants