Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typescript templates #355

Merged
merged 2 commits into from
May 26, 2021
Merged

Conversation

lance
Copy link
Member

@lance lance commented May 19, 2021

This commit also bumps the faas-js-runtime to a github commit hash, since
this is needed for typescript support.

Signed-off-by: Lance Ball lball@redhat.com

Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a TS/JS dev, so caveat emptor but this looks great to me. So glad we have an option for TypeScript dev too now.

Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not Typescript dev, but generally it is looking good

@lance
Copy link
Member Author

lance commented May 24, 2021

Waiting to land this until buildpacks 0.8.0 land. boson-project/buildpacks#82

@lkingland lkingland closed this May 25, 2021
@lkingland lkingland reopened this May 25, 2021
@lkingland
Copy link
Member

lkingland commented May 25, 2021

Sorry, laggy UI resulted in an extraneous PR-closing click.

Bumps the faas-js-runtime dependency to 0.7.1.

fix file globbing on windows

adjust eslint/prettier for windows

improve READMEs

add usage guide

Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance merged commit d3eafe2 into knative:main May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants