Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor typos in node template docs #351

Merged
merged 1 commit into from
May 18, 2021
Merged

fix: minor typos in node template docs #351

merged 1 commit into from
May 18, 2021

Conversation

helio-frota
Copy link
Contributor

No description provided.

zroubalik
zroubalik approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @helio-frota !

lance
lance approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@lance lance merged commit ea0a75a into knative:main May 18, 2021
@helio-frota helio-frota deleted the minor-typos branch May 18, 2021 12:59
jrangelramos added a commit to jrangelramos/func that referenced this pull request Oct 26, 2022
@jrangelramos
chore: update Quarkus patch (knative#351)
7885549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

@zroubalik zroubalik zroubalik approved these changes

@lkingland lkingland lkingland approved these changes

@matejvasek matejvasek Awaiting requested review from matejvasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@helio-frota @lance @zroubalik @lkingland