fix: return JSON in Node.js event template #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejvasek
approved these changes
Nov 6, 2020
matejvasek
reviewed
Nov 6, 2020
| */ | ||
| function verifyUser(context, user) { | ||
| if (!context.cloudevent) { | ||
| return 'No cloud event received'; | ||
| return { | ||
| message: 'No cloud event received' |
There was a problem hiding this comment.
Just out of curiosity, what if it returned:
return '"No cloud event received"'There was a problem hiding this comment.
That would probably parse correctly by the browser.
zroubalik
approved these changes
Nov 6, 2020
The event template was just returning a string, but the default response content type is application/json so browsers were failing to parse the string as JSON. Signed-off-by: Lance Ball <lball@redhat.com>
lance
force-pushed
the
nodejs-return-json
branch
from
597fc8e
to
9c10aad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event template was just returning a string, but the default response
content type is application/json so browsers were failing to parse the string
as JSON.
Signed-off-by: Lance Ball lball@redhat.com