Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Better output of build/deploy/delete commands #206

Merged
merged 2 commits into from Nov 5, 2020

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Nov 5, 2020

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Discussed this with @lkingland, Implementing the spinner properly (so it is not eating the output) may take some time. So I'll proceed with printing some basic info messages, since we are under such a tight deadline.

And we will revisit the Spinner properly for all the commands as a post Dev Preview task.

Build

./faas build -p func                                        
Building function image
Function image has been built, image: docker.io/zroubalik/func:latest

Deploy

 ./faas deploy -p func                                           
Building function image
Function image has been built, image: docker.io/zroubalik/func:latest
Pushing function image to the registry
Deploying function to the cluster
Function deployed at URL: http://func-default.apps.zroubali.devcluster.openshift.com

Update

./faas deploy -p func                                 
Building function image
Function image has been built, image: docker.io/zroubalik/func:latest
Pushing function image to the registry
Deploying function to the cluster
Function updated at URL: http://func-default.apps.zroubali.devcluster.openshift.com

Delete

./faas delete -p func
Removing Knative Service: func

Fixes: #189

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik zroubalik requested a review from a team November 5, 2020 12:33
@zroubalik zroubalik changed the title More output on the build/deploy/delete step [feat] More output on the build/deploy/delete step Nov 5, 2020
@zroubalik zroubalik changed the title [feat] More output on the build/deploy/delete step [feat] Better output of build/deploy/delete commands Nov 5, 2020
@zroubalik zroubalik changed the title [feat] Better output of build/deploy/delete commands feat: Better output of build/deploy/delete commands Nov 5, 2020
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally. Although, I think we are moving away from using using capital "F" for functions. As @rhuss noted in #187

If its to pronounce the concept, then consequently this should be "Function as a Service". But for readability reasons and to avoid a question mark when reading this, I suggest to keep it lower case

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik
Copy link
Contributor Author

@lance ok, fixed in the last commit

@zroubalik zroubalik merged commit ddbb95b into knative:main Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] More output on the build/deploy step
2 participants