Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: list command - improved output #205

Merged
merged 1 commit into from Nov 4, 2020
Merged

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Nov 3, 2020

Depends on #203 - this needs to be merged first

before:

./faas list                                                                                       
myfunc
mygofunc
myqfunc

after:

./faas list                                                                                   
NAME      RUNTIME  URL                                                             KSERVICE  READY
myfunc    node     http://myfunc-default.apps.zroubali.devcluster.openshift.com    myfunc    True
mygofunc  go       http://mygofunc-default.apps.zroubali.devcluster.openshift.com  mygofunc  True
myqfunc   quarkus  http://myqfunc-default.apps.zroubali.devcluster.openshift.com   myqfunc   True

Fixes: #192

@zroubalik zroubalik requested a review from a team November 3, 2020 17:19
@lance
Copy link
Member

lance commented Nov 3, 2020

@zroubalik it looks like you have the commit from #203 here as well. Not a problem, really, but maybe we just close #203 and land this one?

@zroubalik
Copy link
Contributor Author

zroubalik commented Nov 3, 2020

@lance yes, as I mentioned, I'd like to merge #203 first, then I'll rebase this PR. I think that it make sense to have those issues separated, but we can merge the commit in here as well. I don't mind :)

@lance
Copy link
Member

lance commented Nov 3, 2020

Keeping the two commits separate is fine 😊

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] kn faas list should contain more informations
2 participants