Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change default runtime to Node.js HTTP #198

Merged
merged 1 commit into from Nov 2, 2020

Conversation

lance
Copy link
Member

@lance lance commented Oct 30, 2020

I did not implement a prompt if the user doesn't choose. It seems odd to me that a flag would be required. I'm happy to discuss this, however.

Fixes: #191

Signed-off-by: Lance Ball lball@redhat.com

Fixes: knative#191

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance requested a review from a team October 30, 2020 18:41
@lance lance self-assigned this Oct 30, 2020
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance lance merged commit 61cb56a into knative:main Nov 2, 2020
@lance lance deleted the 191-default-to-node branch November 2, 2020 14:27
jrangelramos pushed a commit to jrangelramos/func that referenced this pull request Jun 9, 2022
* Revert ":open_file_folder: update OpenShift specific files"

This reverts commit cbf88a3.

* 📂 update OpenShift specific files

* Restore upstream's Quarkus templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[usability] The default runtime choose is weird and biased
3 participants