fix: delete and `deploy sub-commands respects func.yaml conf

knative · Nov 6, 2020 · d562498 · d562498
1 parent beb838f
commit d562498
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/cmd/delete.go b/cmd/delete.go
@@ -52,7 +52,12 @@ func runDelete(cmd *cobra.Command, args []string) (err error) {
 		return fmt.Errorf("the given path '%v' does not contain an initialized Function.", config.Path)
 	}
 
-	remover, err := knative.NewRemover(config.Namespace)
+	ns := config.Namespace
+	if ns == "" {
+		ns = function.Namespace
+	}
+
+	remover, err := knative.NewRemover(ns)
 	if err != nil {
 		return
 	}

diff --git a/cmd/deploy.go b/cmd/deploy.go
@@ -95,7 +95,12 @@ func runDeploy(cmd *cobra.Command, _ []string) (err error) {
 	pusher := docker.NewPusher()
 	pusher.Verbose = config.Verbose
 
-	deployer, err := knative.NewDeployer(config.Namespace)
+	ns := config.Namespace
+	if ns == "" {
+		ns = function.Namespace
+	}
+
+	deployer, err := knative.NewDeployer(ns)
 	if err != nil {
 		return
 	}