Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Ability to use priority without disrupting running batches #1583

Open
diraol opened this issue Dec 6, 2022 · 3 comments
Open

Ability to use priority without disrupting running batches #1583

diraol opened this issue Dec 6, 2022 · 3 comments

Comments

@diraol
Copy link
Contributor

diraol commented Dec 6, 2022

Hey folks, I have a scenario in which I will have two different flows (with different sets of tests btw) in the same repo.

One is much faster then the other (thus why we want to segregate them).

I've thought about having "two queues with different priorities", which is almost the same as sending PRs with different priorities anyway.
But one drawback of using priority is that i will disrupt the current running batch.

So, my question is: Is there a way to use priority (let's say p=0 and p=1) so that PRs with "p=1" (or batches with p=1) doesn't cancel the current running batch (with p=0)?

@notriddle
Copy link
Member

It's not a feature that Bors has, but there's no reason in principle that it doesn't work that way.

@diraol
Copy link
Contributor Author

diraol commented Jan 16, 2023

Hi @notriddle, I have zero experience with Elixir (even less with bors codebase), can you give me some hints/directions where should I look for in the codebase to propose such change?

@notriddle
Copy link
Member

https://github.com/bors-ng/bors-ng/blob/master/lib/worker/batcher.ex is probably the best place to start

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants