Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: trailling period or not trailing period (full stop)? #8131

Open
trendymail opened this issue Feb 26, 2024 · 3 comments
Open

Typo: trailling period or not trailing period (full stop)? #8131

trendymail opened this issue Feb 26, 2024 · 3 comments

Comments

@trendymail
Copy link

Hello!

Have you checked borgbackup docs, FAQ, and open GitHub issues?

No, except #7946

Is this a BUG / ISSUE report or a QUESTION?

Typo?

Your borg version (borg -V).

1.2.7

Full borg commandline that lead to the problem (leave away excludes and passwords)

borg info <nonexistent repo>

  • Repository <nonexistent repo> does not exist. <= period

borg info <existing repo>::<nonexistent archive>

  • Archive <nonexistent archive> does not exist <= no period

I prefer the version without the trailing dot but maybe borg has another choice to standardize error messages.

Have a great day! :)

@ThomasWaldmann
Copy link
Member

I tend to add a period if it is a complete sentence, but I guess the messages in the existing code are not completely consistent with that rule.

@DarkTechPirate
Copy link

@trendymail @ThomasWaldmann So why this issue is still open , shall i know what need to be modified so that i can start the work ?

@ThomasWaldmann
Copy link
Member

This needs a global review of all messages. All phrases that are complete sentences should end with a dot, except if it introduces some sort of listing, then a colon is of course better or some serious warning/error, then a exclamation mark.

I suggest to do that in master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants