Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borg2: hints for maintainers #6458

Open
ThomasWaldmann opened this issue Mar 15, 2022 · 5 comments
Open

borg2: hints for maintainers #6458

ThomasWaldmann opened this issue Mar 15, 2022 · 5 comments

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Mar 15, 2022

Some hints for Linux / BSD / other OS package maintainers:

libs

additionally to openssl, libacl, libattr, lz4 and zstd, we now also need:

  • libxxhash

some of that code was bundled into previous borg versions, but we just unbundled it for the future (so it won't work any more for borg >= 2.0 if you do not have a working library).

make sure ALL libs have a LIBNAME.pc file for pkg-config because we use that for discovery.

the requirements are documented in our docs / in setup.py.

#6593 removes support for libressl, borg requires openssl >= 1.1.1 now.

python packages

we'll additionally need:

  • argon2-cffi

python 3.9

we'll require that as a minimum for borg >= 2.0.

dist specific hints

freebsd13: no .pc file for openssl
freebsd13: fuse issue #6871
openindiana: #6797

@ThomasWaldmann ThomasWaldmann added this to the helium milestone Mar 15, 2022
@ThomasWaldmann
Copy link
Member Author

https://github.com/borgbackup/borg/pull/6459/files < i used some workarounds there to make some stuff working.

The BORG_LIB......_PREFIX stuff is only needed if there is no working .pc file.

wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this issue Mar 27, 2022
This is needed for future Borgbackup versions, as described in
borgbackup/borg#6458.

libdeflate is a library for fast, whole-buffer DEFLATE-based compression and
decompression.

The supported formats are:

- DEFLATE (raw)
- zlib (a.k.a. DEFLATE with a zlib wrapper)
- gzip (a.k.a. DEFLATE with a gzip wrapper)

libdeflate is heavily optimized.  It is significantly faster than the zlib
library, both for compression and decompression, and especially on x86
processors.  In addition, libdeflate provides optional high compression modes
that provide a better compression ratio than the zlib's "level 9".

libdeflate itself is a library, but the following command-line programs which
use this library are also provided:

* gzip (or gunzip), a program which mostly behaves like the standard equivalent,
  except that it does not yet have good streaming support and therefore does not
  yet support very large files
* benchmark, a program for benchmarking in-memory compression and decompression
@ThomasWaldmann ThomasWaldmann modified the milestones: 1.3.x, 1.3.0b1 Apr 9, 2022
@borgbackup borgbackup deleted a comment from JKBehrens Jun 8, 2022
@ThomasWaldmann ThomasWaldmann changed the title hints for borgbackup package maintainers (master / borg 1.3) hints for borgbackup package maintainers (master / borg2 branch) Jun 26, 2022
@ThomasWaldmann
Copy link
Member Author

ThomasWaldmann commented Jul 27, 2022

Note: I'll clean up a bit in the posts above removing all references to libdeflate (which was removed again by #6834 as borg2 will make much less use of crc32 than borg1 did, so it isn't worth it to have libdeflate as an addtl. requirement).

@borgbackup borgbackup deleted a comment from hexagonrecursion Jul 27, 2022
@borgbackup borgbackup deleted a comment from bket Jul 27, 2022
@borgbackup borgbackup deleted a comment from bket Jul 27, 2022
@ThomasWaldmann ThomasWaldmann modified the milestones: 2.0.0b1, 2.0.0rc1 Jul 27, 2022
@ThomasWaldmann ThomasWaldmann pinned this issue Jul 27, 2022
@ThomasWaldmann ThomasWaldmann changed the title hints for borgbackup package maintainers (master / borg2 branch) hints for borgbackup package maintainers (master branch) Jul 27, 2022
@ThomasWaldmann ThomasWaldmann changed the title hints for borgbackup package maintainers (master branch) borg 2.0 hints for package maintainers Jul 27, 2022
@ThomasWaldmann ThomasWaldmann changed the title borg 2.0 hints for package maintainers borg 2.0: hints for package maintainers Jul 27, 2022
@ThomasWaldmann ThomasWaldmann changed the title borg 2.0: hints for package maintainers borg 2.0: hints for pkg maintainers Jul 27, 2022
@pgerber
Copy link
Contributor

pgerber commented Oct 10, 2022

I wonder there should be some recommendations about packing Borg 1 and Borg 2 separately. Migrating from one to the other will take some time for many people as server need to be updated first (while Borg 1 is still in active use) and then all the clients. For clients the situation gets a bit more involved should they push to multiple repositories where one may not want to update both servers at once. All in all, having both, Borg 1 and Borg 2, available at the same time would be very helpful to users.

So, perhaps there should be a borg1 and borg2 package with separate binaries. A borg metapackage that depends on one of them could be added too and, something like update-alternatives (on Debian) could be provided to have /usr/bin/borg symlinked to borg1 or borg2.

@ThomasWaldmann
Copy link
Member Author

Guess the best idea yet was:

  • do not put the python code into the global python site-packages, but have them in a private space of borg1 and borg 2. the python code is not used by anything else besides borg, so there is no good reason to have this there and it also avoids the conflicts because the package directory of both borg versions is named borg.
  • have borg1 and borg2 cli commands (or even borg1.x and borg2.x) and use a symlink or some dist-specific mechanism to have one of them also as borg cli command

@ThomasWaldmann
Copy link
Member Author

ThomasWaldmann commented Feb 6, 2023

As #7300 is merged now (and is in 2.0.0b5), borg will require platformdirs >=3.0.0, <4.0.0.

This is because it needs 3.0.0 to get the macOS directories right. For Linux, a relatively recent platformdirs 2.x.x would also work.

The <4.0.0 is a precaution to not suddenly/unexpectedly get borg broken in case platformdirs has a future breaking release.

See also: https://github.com/borgbackup/borg/pull/7396/files

@ThomasWaldmann ThomasWaldmann changed the title borg 2.0: hints for pkg maintainers borg2: hints for maintainers Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants