Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selfcheck fails to use curl 7.15.5 because curl --version has non-zero exit status #23

Open
kundor opened this issue Dec 5, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@kundor
Copy link

kundor commented Dec 5, 2016

On my system, I have an old version of curl (7.15.5.) Running curl --version exits with a status of 2.

eio selfcheck runs the code (line 38 of util.py)

        try:
            subprocess.check_output(check_cli, shell=True, stderr=subprocess.STDOUT)
        except subprocess.CalledProcessError:
            msg.append('%r not found or not usable.' % tool_name)

which fails then, even though curl is available.

Perhaps you could instead do something like

        try:
            subprocess.call(check_cli.split(), stderr=subprocess.STDOUT)
        except OSError:
            msg.append('%r not found or not usable.' % tool_name)
@alexamici alexamici self-assigned this Jul 20, 2017
@alexamici alexamici added the bug label Jul 20, 2017
@alexamici alexamici added this to the 1.1.0 milestone Jul 20, 2017
@alexamici
Copy link
Member

Sorry for being so late. I really like your suggestion, thanks!

@alexamici
Copy link
Member

@kundor unfortunately your suggestion or other variations that I tried don't work. The only possibility is to call curl --help instead of --version, can you test is it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants