Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing error on make_histogram(axis::integer(0, 1), dense_storage()) #350

Open
HDembinski opened this issue Feb 4, 2022 · 0 comments

Comments

@HDembinski
Copy link
Collaborator

HDembinski commented Feb 4, 2022

// c++17
auto h = bh::make_histogram(bh::axis::integer(0, 1), bh::dense_storage());

This does not work (and currently shouldn't!) but fails in mysterious ways that are difficult to comprehend. If possible, we should make this work and deprecate make_histogram_with or fail at the earliest. The code interprets the second argument as an axis, but hopefully we can prevent that with better constraints on the template.

@HDembinski HDembinski changed the title Confusing error on make_histogram(axis::integer(0, 1), dense_storage<>()) Confusing error on make_histogram(axis::integer(0, 1), dense_storage()) Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant