Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Fix mscv versions #1224

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ci] Fix mscv versions #1224

wants to merge 1 commit into from

Conversation

vissarion
Copy link
Member

Closes #1223

@vissarion vissarion mentioned this pull request Dec 13, 2023
Open
barendgehrels
barendgehrels approved these changes Feb 10, 2024
View reviewed changes
Copy link
Collaborator

@barendgehrels barendgehrels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

@vissarion
Copy link
Member Author

@barendgehrels even if it looks OK it isn't. The tests look green but there are the same warnings as before. See #1223 (comment)

@barendgehrels
Copy link
Collaborator

@barendgehrels even if it looks OK it isn't. The tests look green but there are the same warnings as before. See #1223 (comment)

Okay... I didn't work in this CI yet, so you can ignore my observations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barendgehrels barendgehrels barendgehrels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSVC CI may not take effect
2 participants
@vissarion @barendgehrels