Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move series membership from Edition to Work #3306

Open
Tracked by #3277
Minnozz opened this issue Mar 4, 2024 · 1 comment · May be fixed by #3277
Open
Tracked by #3277

Move series membership from Edition to Work #3306

Minnozz opened this issue Mar 4, 2024 · 1 comment · May be fixed by #3277

Comments

@Minnozz
Copy link
Contributor

Minnozz commented Mar 4, 2024

The Wikidata property part of the series (P179) links a work (Q386724) to a series of creative works (Q7725310).

work is equivalent to our Work model. We currently store series information in the Book model, which is the parent class of both Work and Edition, but we don't expose Work to the end user: editing a "book" always edits an Edition.

I propose moving series membership from Book to Work, and making Work editable by the end user.

This would be a good time to introduce a Series model so the series of creative works Wikidata key can also be stored.

@Minnozz Minnozz linked a pull request Mar 19, 2024 that will close this issue
4 tasks
@hughrun
Copy link
Contributor

hughrun commented Mar 24, 2024

I agree we need a Series model and that it should not link to Book.

Whether it should be linked to a Work or an Edition however depends on what we mean by "series", and this needs to be made very clear in all documentation and user interfaces to avoid confusion. A couple of examples to illustrate what I mean:

Emma / Jane Austen

  • Everyman's Library
  • Penguin Classics
  • Vintage Classics Austen Series
  • etc

The Light Fantastic / Terry Pratchett

  • Discworld (2)

Personally I would argue that in all the cases for Emma these are imprints rather than a "series", and therefore in our small example above only Discworld is a true series. But this is not necessarily obvious nor a universally held view (especially given that one of the imprints refers to itself as a "series"). The reason this matters is because imprints like "Penguin Classics" are only valid at an Edition level - the Everyman's Library edition is not part of the Penguin Classic "series". So how we define a series determines whether it links to Edition or Work, and vice-versa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants