Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Shelf" column in book list #2484

Open
placoderm opened this issue Dec 9, 2022 · 4 comments · May be fixed by #2562
Open

Add "Shelf" column in book list #2484

placoderm opened this issue Dec 9, 2022 · 4 comments · May be fixed by #2562

Comments

@placoderm
Copy link

Is your feature request related to a problem? Please describe.
When looking at your list of books, there is no indication what shelf a book is on.

Describe the solution you'd like
Add a column that indicates the shelf the book is on.

Describe alternatives you've considered
I know you can filter by shelf, but that's not what I am suggesting. Filtering does not tell me what shelf a book is on, except in a cumbersome way of filtering each shelf till I find the book.

Additional context

2022-12-09 15_37_13-Your books - bookrastinating com — Mozilla Firefox

Apologies if this feature already exists. If it does exist, then it should be more prominent.

@marcusyoung
Copy link

Not what you are suggesting, but if you click on the Move Book drop down on the right you can see where the book is currently shelved. Having a shelf column would be good. It would need to be able to deal with books that are on multiple shelves though (from a layout point of view).

@placoderm
Copy link
Author

placoderm commented Dec 9, 2022

Right, that's a workaround.

But can books be on more than one shelf? I just tried moving a book to a different shelf and it removed it from a previous one. At least I think that is what happened. It's actually kind of confusing. Move implies a "remove" from it's previous location.

But yes, indeed, if books can be on more than one shelf the column would have to indicate all of them.

@marcusyoung
Copy link

Not with the built-in shelves I don't think. But if you move a book to a custom shelf it isn't removed from, e.g the reading shelf. Whether this is intended or a bug with the move functionality I'm not sure!

@placoderm
Copy link
Author

placoderm commented Dec 9, 2022

Right. I have explored a bit more of the move thing (which, for the record, is not directly related to this issue) and indeed "moving" a book to another custom shelf doesn't move it, it just adds it to the shelf. It does seem that the concept of "shelves" is not completely appropriate since a book in real life cannot be on two different shelves unless you own two copies. :-) Really they are categories.

See also this issue I just created for moving books if you are interested: #2485

@joachimesque joachimesque linked a pull request Jan 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants