Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add class to unstyle default styling #49

Open
ibn-akbar opened this issue Nov 18, 2020 · 2 comments
Open

[Feature] Add class to unstyle default styling #49

ibn-akbar opened this issue Nov 18, 2020 · 2 comments

Comments

@ibn-akbar
Copy link

Hi,

Every now and then there's need to add classes for unstyling elements.
Like this:

.button-icon {
  border: unset;
  box-shadow: unset;
}

If we add support for .unstyle class there'll be no need to unset/override styles and it'll come handy.
For example:

.button:not(.unstyle), button:not(.unstyle) {
  ...
}
@ciar4n
Copy link
Contributor

ciar4n commented Nov 22, 2020

Thank you for the suggestion.

I think you make a good point As we are styling the base semantic elements it is indeed important to provide a measure to remove this styling inline.

@JaKXz
Copy link

JaKXz commented Feb 2, 2021

@ciar4n I think there should be a css file exported that has everything except the bonsai-base.css - this would make bonsai much more flexible without imposing the style opinions of the authors on users. It's not "utility-first" if there are a bunch of styles that come with the framework - other libraries/frameworks usually call these "themes" that users can choose from.

I think bonsai is interesting and I don't mean to be harsh because I do like the default styles.

I can recreate what I want by doing

import 'bonsai.css/dist/bonsai-helpers.min.css';
import 'bonsai.css/dist/bonsai-utilities.min.css';

but they still set all the :root variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants