Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.5, added support for ipywidgets>=8.0.0 #169

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

axil
Copy link
Contributor

@axil axil commented Sep 15, 2022

Built upon v3.0.4. Fixes #168

@philippjfr
Copy link
Contributor

Thanks for looking at this. It looks good, but has to be rebased unfortunately.

@axil
Copy link
Contributor Author

axil commented Sep 15, 2022

@philippjfr Well, technically speaking it should be trivial to rebase as it is just one bump in the dependencies:

  "dependencies": {
-    "@jupyter-widgets/base": "^3 || ^4.0.0",
+    "@jupyter-widgets/base": "^6",

Is the current main branch ready for release?

I've written an article about bokeh but I can't publish it because pip install jupyter_bokeh does not work.

@philippjfr
Copy link
Contributor

@mattpap There's a few people asking for a release now. Any chance we could make this change and then release?

@axil
Copy link
Contributor Author

axil commented Sep 15, 2022

@philippjfr I've rebased against main. Now it says "Can't find module core/serialization". But I see the same message on main without my changes, too. Do you know how to deal with it?

@axil
Copy link
Contributor Author

axil commented Sep 15, 2022

@philippjfr @mattpap maybe it is possible to release 3.0.5a alpha version without rebasing? And then gradually complete the serialization improvements? Because as of today jupyter_bokeh is not working at all (e.g. examples fail on fresh install of python + pip install jupyter_bokeh) due to the backwards-incompatible changes in v8.0.0 of ipywidgets.

@mattpap
Copy link
Contributor

mattpap commented Sep 16, 2022

Now it says "Can't find module core/serialization".

This is because main is updated for bokeh 3.0.

@philippjfr
Copy link
Contributor

Would be nice if we could release a fix here before bokeh 3.0 though.

@mattpap
Copy link
Contributor

mattpap commented Sep 16, 2022

Would be nice if we could release a fix here before bokeh 3.0 though.

Sure. I will create a release branch off an earlier commit, merge and release, and then merge back to main.

@mattpap mattpap changed the base branch from main to bokeh-2.4 September 20, 2022 14:43
@mattpap
Copy link
Contributor

mattpap commented Sep 20, 2022

I rebased this and updated lock files. @axil, make sure you use npm 8+, so that lock file version is not downgraded. Looks like everything works with bokeh 2.4.

@mattpap mattpap added this to the 3.0.5 milestone Sep 20, 2022
@mattpap mattpap merged commit 750a77b into bokeh:bokeh-2.4 Sep 20, 2022
mattpap added a commit that referenced this pull request Dec 8, 2022
* v3.0.5, added support for ipywidgets>=8.0.0

* Update nodejs in CI

Co-authored-by: Lev Maximov <lev.maximov@gmail.com>
Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>
mattpap added a commit that referenced this pull request Mar 6, 2023
* v3.0.5, added support for ipywidgets>=8.0.0 (#169)

* v3.0.5, added support for ipywidgets>=8.0.0

* Update nodejs in CI

Co-authored-by: Lev Maximov <lev.maximov@gmail.com>
Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>

* Update yarn.lock

* npm audit fix

* Upgrade webpack and webpack-cli

* Migrate the build to webpack 5

* Add index.js.LICENSE.txt

* Update and unify dependencies

* Update yarn.lock

* Bump version to 3.0.6

* Upgrade actions and nodejs in CI

* Adjust version spec scheme

* Upgrade jupyter-packaging

* Add types to jupyter_bokeh/widgets.py

* Remove unused imports

* Rename trigger_{json_->}event()

* Update event handling to Bokeh 3.0

* Update .gitignore

---------

Co-authored-by: Lev Maximov <axil.github@gmail.com>
Co-authored-by: Lev Maximov <lev.maximov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work with the latest version of ipywidgets
3 participants