Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The histogram is not loading when the output is in HTML format #392

Open
meldyer1 opened this issue Jan 7, 2023 · 3 comments
Open

The histogram is not loading when the output is in HTML format #392

meldyer1 opened this issue Jan 7, 2023 · 3 comments

Comments

@meldyer1
Copy link

meldyer1 commented Jan 7, 2023

Is your feature request related to a problem? Please describe.
When add -O html to the ghz command, the html output:

  1. Does not display a histogram.
  2. Cannot download the json or csv attachments.

The problem was that in the dependencies, the britecharts versions (in css and javascript) were out of date.

I had to modify to the code in the HTML attachment fix the issue. However, when I hovered over the histogram, it did not display anything.

Describe the solution you'd like
I am requesting for an update of britecharts from version 2 to version 3.

Describe alternatives you've considered
I have modified the HTML webpage by changing the following lines:

  1. <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/britecharts/dist/css/britecharts.min.css" type="text/css" /></head>
    

to

  1. <script src="https://cdn.jsdelivr.net/npm/britecharts@2/dist/bundled/britecharts.min.js"></script>

to

<script src="https://cdn.jsdelivr.net/npm/britecharts@3/dist/bundled/britecharts.min.js"></script>

  1. Removing tooltip.numberFormat('');
  2. And then replacing

tooltip.valueFormatter(function(v) { var percent = v / count * 100; return v + ' ' + '(' + Number.parseFloat(percent).toFixed(1) + ' %)'; })

with

tooltip.numberFormat(function(v) { var percent = v / count * 100; return v + ' ' + '(' + Number.parseFloat(percent).toFixed(1) + ' %)'; })

Additional context
Before any changes were made, this is what I saw
image

After making modifications to the html webpage, I saw
image

@meldyer1
Copy link
Author

meldyer1 commented Jan 7, 2023

I meant to say that

<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/britecharts/dist/css/britecharts.min.css" type="text/css" /></head>

was updated to

<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/britecharts@3/dist/css/britecharts.min.css" type="text/css" /></head>

@rlindooren
Copy link
Contributor

Also facing this issue.

The URL https://cdn.jsdelivr.net/npm/britecharts@2/dist/bundled/britecharts.min.js
results in a 403: Package size exceeded the configured limit of 100 MB.

@rlindooren
Copy link
Contributor

Suggested change: #402 (temporary until the CDN has been fixed?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants