Skip to content
This repository has been archived by the owner on Mar 15, 2020. It is now read-only.

Uvicorn 0.5 #183

Closed
tomchristie opened this issue Mar 4, 2019 · 6 comments
Closed

Uvicorn 0.5 #183

tomchristie opened this issue Mar 4, 2019 · 6 comments
Assignees
Labels
maintenance This is about releasing/versioning/CICD/etc third-party Related to a third-party repo or project
Milestone

Comments

@tomchristie
Copy link

Uvicorn 0.5 has been released.

  • Auto-reloading will now take effect, without having to use uvicorn from the console.
  • Multi-worker support is here.

I've just noticed you import StatReloader from uvicorn - which is technically private API - you'll find that's broken with the upgrade.

I'd suggest the following:

  • Stop importing StatReloader - instead just use reload=True in uvicorn.run(...)
  • Pin uvicorn to 0.5.*
  • If you want to enable multiworker support (it's not the default yet) then use workers=multiprocessing.cpu_count().
@florimondmanca
Copy link
Member

Hi @tomchristie, glad to know multi-worker support has arrived in Uvicorn. Thanks a lot for reporting this here. Will take a look at this soon!

@florimondmanca florimondmanca added priority Important stuff maintenance This is about releasing/versioning/CICD/etc third-party Related to a third-party repo or project labels Mar 4, 2019
@florimondmanca florimondmanca added this to the v0.12.3 milestone Mar 4, 2019
@waghanza
Copy link

waghanza commented Mar 4, 2019

Hi @tomchristie,

Do you plan top merge uvicorn with gunicorn ?

Now that python 2 is dropped ?

Regards,

@florimondmanca florimondmanca self-assigned this Mar 4, 2019
@tomchristie
Copy link
Author

@waghanza Not especially - I'd be totally happy for the ASGI worker class to be a built-in option for gunicorn, but I've no idea if there's any appetite for that.

@waghanza
Copy link

waghanza commented Mar 4, 2019

let's ask @benoitc to add ASGI support 😛

@florimondmanca
Copy link
Member

@waghanza I'd personally be in favour of this too, but perhaps the discussion should be ported over the uvicorn/gunicorn repos. You may want to chime in here: benoitc/gunicorn#1380 😉

@florimondmanca florimondmanca removed this from the v0.12.3 milestone Mar 4, 2019
@florimondmanca florimondmanca added blocked This issue is blocked by an external cause and removed blocked This issue is blocked by an external cause labels Mar 4, 2019
@florimondmanca florimondmanca modified the milestones: v0.13.0, v0.12.4 Mar 5, 2019
@florimondmanca
Copy link
Member

Deployed 🎉 https://pypi.org/project/bocadillo/0.12.4/ Will add multi-worker in a future release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance This is about releasing/versioning/CICD/etc third-party Related to a third-party repo or project
Projects
None yet
Development

No branches or pull requests

3 participants