Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2-2-4-linked-list, contains()'s tests accept this wrong solution #168

Open
obaibula opened this issue Apr 10, 2023 · 0 comments
Open

2-2-4-linked-list, contains()'s tests accept this wrong solution #168

obaibula opened this issue Apr 10, 2023 · 0 comments

Comments

@obaibula
Copy link

The corrupted code:

@Override
    public boolean contains(T element) {
        requireNonNull(element);
        Node<T> current = head;

        if(!isEmpty()){
            while (current.next != null){
                if (current.element.equals(element)){
                    return true;
                }
                current = current.next;
            }
        }

        return false;
    }

It would be great to check in tests for the presence of the last element in the list.

@shryhus shryhus added this to To do in Java Fundamentals Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant