Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Failure #94

Open
dAgbeve opened this issue Aug 1, 2020 · 5 comments
Open

Build Failure #94

dAgbeve opened this issue Aug 1, 2020 · 5 comments

Comments

@dAgbeve
Copy link

dAgbeve commented Aug 1, 2020

Hi All,

I am trying to build and getting an error concerning explicit type casting.

This is just to give a heads-up on this.

facil-build-error

@boazsegev
Copy link
Owner

boazsegev commented Aug 1, 2020

Hi @dAgbeve ,

Thank you for opening this issue.

In order to help you, could you let me know which version of facil.io you are using (or which branch)? Which compiler?

Thanks,
Bo.

P.S.

  1. It would be better if you pasted the log as a code block rather than an image.

  2. I think these errors are lying to you. There's little wrong with the casts, as I made sure the functions use intptr_t where casting between a function that accepts a number to one that accepts a pointer.

@dAgbeve
Copy link
Author

dAgbeve commented Aug 1, 2020

@boazsegev thank you for the prompt response.

The 0.7.x branch was cloned and for the compiler, GCC version 10.2.0.

P.Ses are well noted.

Thank you,
aAgbeve.

@boazsegev
Copy link
Owner

Hi @dAgbeve ,

Thanks for the quick reply.

GCC 10.2.0... this might take me a while. I'll need to install it and test with it.

I'll get back to you as soon as I can.

Bo.

@boazsegev
Copy link
Owner

I'm installing GCC 10.2 today... (mine was 5.x, and I was happily coding away with abandoned disregard).

Just one more question - it seems to me, from the log, that all warning are treated as errors (perhaps you are building it with DEBUG set)...

Does the build fail when DEBUG is unset (or warnings are allowed to call out without turning to errors)?

FYI: GCC's own code doesn't compile without warnings, so this flag will prevent GCC from compiling as well.

@dAgbeve
Copy link
Author

dAgbeve commented Aug 2, 2020

Great!

Yes, the $(WARNING) flags are what is preventing the compilation, as that is what they were meant to do. Taking that out, compilation was successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants