Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Passing an empty string to pageFilenameFromPath() results in error. #66

Open
fabianmichael opened this issue Jun 17, 2021 · 2 comments
Open
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@fabianmichael
Copy link
Contributor

In one of my projects, it seems that the pageFilenameFromPath() sometimes gets an empty string as parameter. In that case, the pathinfo() function does not return all expected keys, but only the following:

array(2) {
  ["basename"]=>
  string(0) ""
  ["filename"]=>
  string(0) ""
}

This leads to the following exception: Notice: Undefined index: dirname (see https://github.com/bnomei/kirby3-autoid/blob/master/classes/AutoIDDatabase.php#L233)

As I don’t know exactly why an empty ID gets passed to the method, I did not create a fix that just supresses the error. Maybe this would be sufficient, but maybe the issue is rooted somewhere else?

@bnomei bnomei self-assigned this Jun 28, 2021
@bnomei bnomei added bug Something isn't working question Further information is requested labels Jun 28, 2021
@bnomei
Copy link
Owner

bnomei commented Jun 28, 2021

like you said it might be better to find the issue that to add a quick fix and just check for en empty value and be done. :-)

its used in findByID and deleteByID which are kind of the core.

can you tell me a bit more how and when it happens? what data is involved?
does it happen in panel or frontend?
when panel on saving/creating stuff?
when in frontend can the set of IDs refrenced by autoid reduced to a human verifiable amount?
is it somehow reproducable?
does removing the index and creating it again solve the issue?

@fabianmichael
Copy link
Contributor Author

@bnomei Will try to figure it out …

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants