Error at end of resolve if bndrun editor closed during resolution

[njbartlett]

Open a bndrun file in the editor and start a resolve operation (Ctrl-R or Resolve button on the toolbar). While resolution is ongoing, close the editor.

The results dialog will appear. Click Finish... an error dialog appears. "Failed to reload bnd edit model. Argument not valid". There are no errors in the Eclipse Error Log.

Note sure what we should do here. Perhaps cancel the ongoing resolve when the editor closes?

[pkriens]

I'd prefer to have the resolve solution window unconnected to the bndedit model. Maybe the connection can be to the actual file so then when you make changes (the optionals I guess) and resolve it opens the editor again. I'd like to be able to have the resolve window open while I can do stuff in the rest of Eclipse, i.e. not modal.

[njbartlett]

Agreed about having a non-modal display of the results.

I think it's useful to have the resolution connected to the edit model because you can resolve based on the unsaved contents of the editor. Most resolutions are quick so this becomes just an editing task.

Perhaps we should have a check in Finish step: if there is no editor associated with the resolve then persist straight to the file. This would further enable us to trigger resolution from outside the context of an editor, e.g. the right-click menu of a bndrun file in the Project Explorer.