Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[premium] fold for docblocks #980

Closed
str opened this issue Jan 28, 2020 · 4 comments
Closed

[premium] fold for docblocks #980

str opened this issue Jan 28, 2020 · 4 comments

Comments

@str
Copy link

str commented Jan 28, 2020

Feature description or problem with existing feature
I understand one of the premium features is the language-aware-folding for PHP. One of the great features in Eclipse or PhpStorm is the docblock folding, that shows the first line of the dockblock.

Native VSCode folding for comments, sucks, big time. It leaves 2 useless lines after folding.

This has been asked before, but ignored.

Describe the solution you'd like
Can we add that feature to the premium version?

Additional context
Thank you for your great work.

@KapitanOczywisty
Copy link
Contributor

@str
Copy link
Author

str commented Jan 28, 2020

IC. What if we leave this as a backlog, to return when it's possible. Let's see if there is any other related issue that would help with this.

Meanwhile, if it's not that complicated, can we remove the useless 2nd line of the folded dockblock?

image

@KapitanOczywisty
Copy link
Contributor

This should be easy #772

If there is way to detect folding event/change, this could be useful for original request: https://code.visualstudio.com/api/references/vscode-api#DecorationRenderOptions

@bmewburn
Copy link
Owner

I think this would need improvements to the LSP folding protocol to implement the vscode linked issue. The last line of folded comments has been removed in 1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants