Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell check underline ignores tabs in text #256

Open
beaswag opened this issue Apr 15, 2021 · 2 comments
Open

Spell check underline ignores tabs in text #256

beaswag opened this issue Apr 15, 2021 · 2 comments

Comments

@beaswag
Copy link

beaswag commented Apr 15, 2021

the red underline that appears under words the spellcheck doesn't like completely ignores tabs in the original text, resulting in the underline not lining up with the word.

image
image

@blurymind
Copy link
Owner

blurymind commented Jul 10, 2021

I think the problem is that the Tab offsets the word and the linter doesnt take that into account at all

@blurymind
Copy link
Owner

blurymind commented Jul 10, 2021

This is kind of a hard one to fix due to how tabs and spaces are treated as the same symbol there.

If anyone would like to try a pr, you would need to somehow keep tabs at
https://github.com/YarnSpinnerTool/YarnEditor/blob/master/src/js/libs/spellcheck_ace.js#L72

and account for them all the way to
https://github.com/YarnSpinnerTool/YarnEditor/blob/master/src/js/libs/spellcheck_ace.js#L126

ace editor kind of makes this extra funky too.I couldnt figure out a clean way to fix it, but would welcome one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants