Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize data that is exported #117

Open
blurymind opened this issue Feb 26, 2020 · 0 comments
Open

Sanitize data that is exported #117

blurymind opened this issue Feb 26, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@blurymind
Copy link
Owner

blurymind commented Feb 26, 2020

I received some reports from Gdevelop users that their yarn exported json files were crashing the bondagejs parser. Some of these visualnovel developers using yarn like to copy stuff from the web and paste it into their dialogue, then save that.
Unfortunately they may copy some invalid characters or even ones that are invisible and pass that off to the game engine, where the bondagejs parser will crash.
People encountering this issue tipically create a new yarn file and paste their dialogue into it in order to fix their issue.

I suggest adding some sanitation when yarn saves files or dialogue nodes - to clean them up from crap data that would corrupt the json file.

Additionally sometimes putting spaces or odd characters when entering node names also leads to problems- so maybe the node title field needs to be validated too

Might do a PR, but would like to get some feedback first

@FaultyFunctions FaultyFunctions added the enhancement New feature or request label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants