Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates needed to remove DeprecationWarnings #675

Open
padraic-shafer opened this issue Mar 4, 2024 · 5 comments
Open

Updates needed to remove DeprecationWarnings #675

padraic-shafer opened this issue Mar 4, 2024 · 5 comments

Comments

@padraic-shafer
Copy link
Contributor

Some housekeeping is needed to respond to multiple DeprecationWarnings that are raised during testing.

  • DeprecationWarning: on_event is deprecated, use lifespan event handlers instead.
  • DeprecationWarning: product is deprecated as of NumPy 1.25.0, and will be removed in NumPy 2.0. Please use prod instead.
    • I will submit a PR for this.
  • DataFrame._data is deprecated and will be removed in a future version. Use public APIs instead.
    • This comes from the cachey dependency. It will likely require an upstream PR.
@padraic-shafer
Copy link
Contributor Author

Submitted PR #676 for the FastAPI lifespan events

@padraic-shafer
Copy link
Contributor Author

Submitted PR #677 to use numpy.prod() rather than numpy.product().

@padraic-shafer
Copy link
Contributor Author

padraic-shafer commented Mar 7, 2024

  • DataFrame._data is deprecated and will be removed in a future version. Use public APIs instead.
    • This comes from the cachey dependency. It will likely require an upstream PR.

It looks like Pandas wants to remove its BlockManager. The roadmap is not yet clear on what the replacement will look like, and there is not suggested alternate for accessing the blocks. This access has remained stable for several years, and discussions suggest there is no hurry to change that.

So our best option here is probably to just ignore this warning. We could specifically filter it with action: ignore:DataFrame._data is deprecated and will be removed in a future version. Use public APIs instead.:DeprecationWarning.

References

@padraic-shafer
Copy link
Contributor Author

Submitted PR #682 to ignore the warnings from cachey.nbytes().

@danielballan
Copy link
Member

Maybe we can solve the cachey problem by simply dropping the dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants