Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the theme selector menu #3892

Open
brodieavoult opened this issue May 7, 2024 · 3 comments
Open

Simplify the theme selector menu #3892

brodieavoult opened this issue May 7, 2024 · 3 comments
Labels
feature-request A request for a new feature

Comments

@brodieavoult
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I personally feel like the way that the theme selector in the Desktop site is split into two sections (?) is a little unnecessary and makes it feels a little clunky, and should be simplified.

Describe the solution you'd like

I've made a little mock-up to show how it could be improved upon. Maybe this isn't a perfect solution, but it's better than how it is currently.
Bluesky-Theme-Selector

@brodieavoult brodieavoult added the feature-request A request for a new feature label May 7, 2024
@mary-ext
Copy link
Contributor

mary-ext commented May 7, 2024

Which dark theme variant should it use if you've set it to System?

@brodieavoult
Copy link
Contributor Author

I don't see how that sort of behavior would be changed by my suggestion, so I suppose it would just behave the same as it does currently (Light for Light mode, and Dim for Dark mode). This is purely just an UX change.

@mary-ext
Copy link
Contributor

mary-ext commented May 9, 2024

Seems unclear to me though how that'd be the case? Unless you intend for it to be like so:

image

System mode should still let you change between Dim and Dark, hence why they're separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants